Skip to content

[All] CSpell の導入 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 19, 2025
+290 −0
Merged

[All] CSpell の導入 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
43ba211
chore: add cspell configuration with jsonc format
blendthink Apr 19, 2025
4e31be6
chore: add cspell and software terms dictionary
blendthink Apr 19, 2025
3ee8f84
chore: add dart, flutter and sql dictionaries for cspell
blendthink Apr 19, 2025
2d8631f
chore: configure cspell to use dart, flutter and sql dictionaries
blendthink Apr 19, 2025
e7e97c4
chore: add trailing commas to cspell configuration
blendthink Apr 19, 2025
6ac63ff
chore: add configuration files to cspell ignore paths
blendthink Apr 19, 2025
3166b17
chore: add code-spell-checker to recommended extensions
blendthink Apr 19, 2025
0f9a13c
chore: add CODEOWNERS to cspell words
blendthink Apr 19, 2025
594932c
ci: add spell check workflow with tool-versions support
blendthink Apr 19, 2025
a44bef3
chore: add bunx and marocchino to cspell words
blendthink Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/check-spell.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Check Spell

on:
pull_request:

jobs:
check-spell:
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: Read .tool-versions
uses: marocchino/tool-versions-action@18a164fa2b0db1cc1edf7305fcb17ace36d1c306 # v1.2.0
id: versions
- name: Setup bun
uses: oven-sh/setup-bun@4bc047ad259df6fc24a6c9b0f9a0cb08cf17fbe5 # v2.0.1
with:
bun-version: ${{ steps.versions.outputs.bun }}
Comment on lines +12 to +18
Copy link
Contributor

@tatsutakein tatsutakein Apr 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits-badge

ここは mise のアクション使うと 1 アクションで実現できます 🙋
https://github.com/jdx/mise-action

Suggested change
- name: Read .tool-versions
uses: marocchino/tool-versions-action@18a164fa2b0db1cc1edf7305fcb17ace36d1c306 # v1.2.0
id: versions
- name: Setup bun
uses: oven-sh/setup-bun@4bc047ad259df6fc24a6c9b0f9a0cb08cf17fbe5 # v2.0.1
with:
bun-version: ${{ steps.versions.outputs.bun }}
- name: mise action
uses: jdx/mise-action@5083fe46898c414b2475087cc79da59e7da859e8 # v2.1.11

Copy link
Collaborator Author

@blendthink blendthink Apr 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tatsutakein
これ考えたのですが、余計なもののインストールが走っちゃう気がしてやめました、、！🙏

何か絞る方法があれば教えていただけると助かります🙏

Copy link
Contributor

@tatsutakein tatsutakein Apr 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、なるほど！そこを懸念されていたのですね 🙇

何を気にしているのか次第なところではありますが…！
インストールの時間を気にされているようであれば jdx/mise-action はキャッシュしてくれるのでわりとスムーズにインストールできるかなと思ってます。
単純に使用しないものまでインストールが走ってしまうことを気にされているようであれば現状のままで良い気がします 🙏

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

悩ましいところですが、ひとまずは今のままでいかせてください🙏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おけまるです！
決めの問題だと思うので、問題ないように思います 🙆

- name: Install dependencies
run: bun install --frozen-lockfile
- name: Run spell check
run: bunx cspell .
5 changes: 5 additions & 0 deletions .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"recommendations": [
"streetsidesoftware.code-spell-checker",
],
}
Loading
Loading