[All] CSpell の導入 #21
Merged
[All] CSpell の導入 #21
+290
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatsutakein
reviewed
Apr 19, 2025
Comment on lines
+12
to
+18
| - name: Read .tool-versions | ||
| uses: marocchino/tool-versions-action@18a164fa2b0db1cc1edf7305fcb17ace36d1c306 # v1.2.0 | ||
| id: versions | ||
| - name: Setup bun | ||
| uses: oven-sh/setup-bun@4bc047ad259df6fc24a6c9b0f9a0cb08cf17fbe5 # v2.0.1 | ||
| with: | ||
| bun-version: ${{ steps.versions.outputs.bun }} |
There was a problem hiding this comment.
ここは mise のアクション使うと 1 アクションで実現できます 🙋
https://github.com/jdx/mise-action
Suggested change
| - name: Read .tool-versions | |
| uses: marocchino/tool-versions-action@18a164fa2b0db1cc1edf7305fcb17ace36d1c306 # v1.2.0 | |
| id: versions | |
| - name: Setup bun | |
| uses: oven-sh/setup-bun@4bc047ad259df6fc24a6c9b0f9a0cb08cf17fbe5 # v2.0.1 | |
| with: | |
| bun-version: ${{ steps.versions.outputs.bun }} | |
| - name: mise action | |
| uses: jdx/mise-action@5083fe46898c414b2475087cc79da59e7da859e8 # v2.1.11 |
There was a problem hiding this comment.
@tatsutakein
これ考えたのですが、余計なもののインストールが走っちゃう気がしてやめました、、！🙏
何か絞る方法があれば教えていただけると助かります🙏
There was a problem hiding this comment.
あ、なるほど！そこを懸念されていたのですね 🙇
何を気にしているのか次第なところではありますが…！
インストールの時間を気にされているようであれば jdx/mise-action はキャッシュしてくれるのでわりとスムーズにインストールできるかなと思ってます。
単純に使用しないものまでインストールが走ってしまうことを気にされているようであれば現状のままで良い気がします 🙏
There was a problem hiding this comment.
悩ましいところですが、ひとまずは今のままでいかせてください🙏
There was a problem hiding this comment.
おけまるです！
決めの問題だと思うので、問題ないように思います 🙆
tatsutakein
approved these changes
Apr 19, 2025
Comment on lines
+12
to
+18
| - name: Read .tool-versions | ||
| uses: marocchino/tool-versions-action@18a164fa2b0db1cc1edf7305fcb17ace36d1c306 # v1.2.0 | ||
| id: versions | ||
| - name: Setup bun | ||
| uses: oven-sh/setup-bun@4bc047ad259df6fc24a6c9b0f9a0cb08cf17fbe5 # v2.0.1 | ||
| with: | ||
| bun-version: ${{ steps.versions.outputs.bun }} |
There was a problem hiding this comment.
おけまるです！
決めの問題だと思うので、問題ないように思います 🙆
|
レビューありがとうございます！ |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #17
概要
スペルチェックツール（CSpell）を導入し、プルリクエスト時に自動チェックを実行するように設定しました。
詳細
導入したツールと設定
cspell.jsonc）.github/workflows/check-spell.yaml）.tool-versionsから bun のバージョンを読み込み.vscode/extensions.json）変更の背景
その他