-
Notifications
You must be signed in to change notification settings - Fork 12
Conform beamline modules to use shared components and update dodal connect #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oliwenmandiamond
wants to merge
15
commits into
main
Choose a base branch
from
shared_beamline_module_dodal_connect_improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conform beamline modules to use shared components and update dodal connect #1532
oliwenmandiamond
wants to merge
15
commits into
main
from
shared_beamline_module_dodal_connect_improvements
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
==========================================
- Coverage 98.74% 98.73% -0.01%
==========================================
Files 242 250 +8
Lines 8747 8809 +62
==========================================
+ Hits 8637 8698 +61
- Misses 110 111 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
* add PGM support for i06 #116 * add PGM support using i06_shared for i06 and i06-1 * add PGM support for i06 #116 * add PGM support using i06_shared for i06 and i06-1 * configure _BEAMLINE_SHARED to include i06_shared for i06 and i06-1 * fix spell mistake * Update src/dodal/beamlines/i06_shared.py remove name argument as it is the same as default value Co-authored-by: oliwenmandiamond <[email protected]> --------- Co-authored-by: oliwenmandiamond <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1530
Instructions to reviewer on how to test:
As were using python code as configuration, I've had to adjust the
dodal connect
command to work with some configuration to chain together beamline modules. I think long term, we should use YAML/TOML for device initiation so that we can easily break down beamline modules to be more modular and then can easily include / import shared devices automatically and then won't need the changes fordodal connect
.Checks for reviewer
dodal connect ${BEAMLINE}