Skip to content

Conversation

oliwenmandiamond
Copy link
Contributor

@oliwenmandiamond oliwenmandiamond commented Sep 15, 2025

Fixes #1530

Instructions to reviewer on how to test:

  1. Check tests pass
  2. Check dodal connect works with shared beamline modules
  3. Documentation makes sense
  4. Beamlines conform to standards

As were using python code as configuration, I've had to adjust the dodal connect command to work with some configuration to chain together beamline modules. I think long term, we should use YAML/TOML for device initiation so that we can easily break down beamline modules to be more modular and then can easily include / import shared devices automatically and then won't need the changes for dodal connect.

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 99.08257% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.73%. Comparing base (24a51cf) to head (02b853f).

Files with missing lines Patch % Lines
src/dodal/utils.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1532      +/-   ##
==========================================
- Coverage   98.74%   98.73%   -0.01%     
==========================================
  Files         242      250       +8     
  Lines        8747     8809      +62     
==========================================
+ Hits         8637     8698      +61     
- Misses        110      111       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oliwenmandiamond oliwenmandiamond marked this pull request as ready for review September 16, 2025 08:27
@oliwenmandiamond oliwenmandiamond requested a review from a team as a code owner September 16, 2025 08:27
oliwenmandiamond and others added 7 commits September 18, 2025 09:11
* add PGM support for i06 #116

* add PGM support using i06_shared for i06 and i06-1

* add PGM support for i06 #116

* add PGM support using i06_shared for i06 and i06-1

* configure _BEAMLINE_SHARED to include i06_shared for i06 and i06-1

* fix spell mistake

* Update src/dodal/beamlines/i06_shared.py

remove name argument as it is the same as default value

Co-authored-by: oliwenmandiamond <[email protected]>

---------

Co-authored-by: oliwenmandiamond <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standard way to define device once that is shared between multiple end statations

2 participants