-
Notifications
You must be signed in to change notification settings - Fork 12
Create common mirror classes and populate I05s mirrors #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
==========================================
+ Coverage 98.74% 98.75% +0.01%
==========================================
Files 243 243
Lines 8769 8859 +90
==========================================
+ Hits 8659 8749 +90
Misses 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Blocked by https://jira.diamond.ac.uk/browse/I05-731 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Mostly style suggestions. The only one I think might be a mistake is the enum names
|
I'm really dislike defining devices in shared and then just redefining them on the beamline branch as we have config in multiple places for the same thing e.g from dodal.beamlines.beamline_utils.i05_shared import m3mj6_switching_mirror
...
@device_factory()
def m3mj6() -> XYZPiezoSwitchingMirror:
return m3mj6_switching_mirror()It's not needed because blueapi supports loading in multiple beamlines e.g i05 and i05_shared. It's only kinda needed for dodal connect which this change addresses #1532 and needs discussion on standard of shared beamlines |
|
@oliwenmandiamond thanks I'm on your side with that, but atm I think we just stick to what we have. |
Fixes #1424
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}