Skip to content

Conversation

Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny commented Sep 1, 2025

Fixes #1495
Last part of #1467

  • Moved EnergySetter to common as it is now generic.
  • Added preparable and flyable to EnergySetter.
  • Added test,

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny linked an issue Sep 1, 2025 that may be closed by this pull request
4 tasks
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.73%. Comparing base (12a2407) to head (e8bf28b).

Additional details and impacted files
@@                           Coverage Diff                            @@
##           1480-make-apple2-preparable-and-flyable    #1496   +/-   ##
========================================================================
  Coverage                                    98.73%   98.73%           
========================================================================
  Files                                          236      236           
  Lines                                         8694     8716   +22     
========================================================================
+ Hits                                          8584     8606   +22     
  Misses                                         110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Relm-Arrowny Relm-Arrowny changed the base branch from main to 1480-make-apple2-preparable-and-flyable September 3, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make apple2 and PGM start flying in sync.
1 participant