ci: add riot hash to DD_TAGS [backport 3.10] #14310
Open
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the riot environment hash to the tags sent with tests, so that runs of the same test in different environments get different test fingerprints in the backend. This avoids an issue where a test that passes in one environment and fails in another would end up being marked as flaky. To avoid breaking tests that check for tags, a new `_CI_DD_TAGS` environment variable was added that only sets the tags for the CI environment, but does not affect the tracer being tested. - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Brett Langdon <[email protected]> (cherry picked from commit 02b1c2b)
vitor-de-araujo
requested review from
anmarchenko,
christophe-papazian,
brettlangdon and
gnufede
|
|
vitor-de-araujo
added
changelog/no-changelog
gnufede
approved these changes
Aug 14, 2025
brettlangdon
approved these changes
Aug 14, 2025
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 289 ± 5 ms. The average import time from base is: 303 ± 7 ms. The import time difference between this PR and base is: -13.6 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-08-20 11:48:40 Comparing candidate commit 333bb84 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 546 metrics, 3 unstable metrics. scenario:iastaspects-rstrip_aspect
|
2 tasks
juanjux
pushed a commit
that referenced
this pull request
Aug 20, 2025
Multiple PRs experienced `tests/smoke_test.py` failing on build_base_venv jobs, blocking merging those PRs, examples include - #14310 - #14353 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 02b1c2b from #14296 to 3.10.
Add the riot environment hash to the tags sent with tests, so that runs of the same test in different environments get different test fingerprints in the backend. This avoids an issue where a test that passes in one environment and fails in another would end up being marked as flaky.
To avoid breaking tests that check for tags, a new
_CI_DD_TAGSenvironment variable was added that only sets the tags for the CI environment, but does not affect the tracer being tested.Checklist
Reviewer Checklist