Skip to content

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Aug 20, 2025

Multiple PRs experienced tests/smoke_test.py failing on build_base_venv jobs, blocking merging those PRs, examples include

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Aug 20, 2025

CODEOWNERS have been resolved as:

.gitlab/templates/cached-testrunner.yml                                 @DataDog/python-guild @DataDog/apm-core-python

@taegyunkim taegyunkim changed the title [do not merge]: check to see if smoke test fails here too chore(build): turn off extension hash cache on 3.10 Aug 20, 2025
@taegyunkim taegyunkim marked this pull request as ready for review August 20, 2025 14:21
@taegyunkim taegyunkim requested review from a team as code owners August 20, 2025 14:21
@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 20, 2025
Copy link
Contributor

github-actions bot commented Aug 20, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 280 ± 3 ms.

The average import time from base is: 284 ± 3 ms.

The import time difference between this PR and base is: -3.2 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.109 ms (0.75%)
ddtrace.bootstrap.sitecustomize 1.389 ms (0.50%)
ddtrace.bootstrap.preload 1.389 ms (0.50%)
ddtrace.internal.remoteconfig.client 0.681 ms (0.24%)
ddtrace 0.721 ms (0.26%)
ddtrace.internal._unpatched 0.067 ms (0.02%)
subprocess 0.036 ms (0.01%)
contextlib 0.036 ms (0.01%)
json 0.031 ms (0.01%)
json.decoder 0.031 ms (0.01%)
re 0.031 ms (0.01%)
enum 0.031 ms (0.01%)
types 0.031 ms (0.01%)

@juanjux juanjux enabled auto-merge (squash) August 20, 2025 14:27
@P403n1x87
Copy link
Contributor

Is this because we miss some other CI fixes on this release branch?

@pr-commenter
Copy link

pr-commenter bot commented Aug 20, 2025

Benchmarks

Benchmark execution time: 2025-08-20 15:21:44

Comparing candidate commit 59edd6e in PR branch taegyunkim/trigger-build with baseline commit 47b9f8e in branch 3.10.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 499 metrics, 3 unstable metrics.

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+581.736ns; +659.023ns] or [+15.702%; +17.788%]

scenario:telemetryaddmetric-1-distribution-metric-1-times

  • 🟥 execution_time [+404.006ns; +453.147ns] or [+13.678%; +15.341%]

@juanjux juanjux merged commit 6932159 into 3.10 Aug 20, 2025
848 of 854 checks passed
@juanjux juanjux deleted the taegyunkim/trigger-build branch August 20, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants