Skip to content

Move to ClassTag instead of Manifest: #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

Move to ClassTag instead of Manifest: #729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pulsar4s-circe/src/main/scala/com/sksamuel/pulsar4s/circe/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ import org.apache.pulsar.client.api.Schema
import org.apache.pulsar.client.impl.schema.SchemaInfoImpl
import org.apache.pulsar.common.schema.{SchemaInfo, SchemaType}

import java.nio.charset.StandardCharsets
import scala.annotation.implicitNotFound
import scala.reflect.{ClassTag, classTag}

/**
* Automatic MessageWriter and MessageReader derivation
Expand All @@ -30,7 +32,7 @@ package object circe {

@implicitNotFound(
"No Encoder for type ${T} found. Use 'import io.circe.generic.auto._' or provide an implicit Encoder instance ")
implicit def circeSchema[T: Manifest](implicit
implicit def circeSchema[T: ClassTag](implicit
encoder: Encoder[T],
decoder: Decoder[T],
printer: Json => String = Printer.noSpaces.print): Schema[T] = new Schema[T] {
Expand All @@ -40,7 +42,7 @@ package object circe {
io.circe.jawn.decode[T](new String(bytes, StandardCharsets.UTF_8)).fold(throw _, identity)
override def getSchemaInfo: SchemaInfo = {
SchemaInfoImpl.builder()
.name(manifest[T].runtimeClass.getCanonicalName)
.name(classTag[T].runtimeClass.getCanonicalName)
.`type`(SchemaType.BYTES)
.schema(Array.empty[Byte])
.build()
Expand Down
Loading