Move to ClassTag instead of Manifest: #729
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as that one is being deprecated and so results in a compiler warning.
|
@judu Is there more to do to get this merged? I noticed that you allowed the pipeline to run, super thanks for that, but I would like to get it merged, to not have to run a adjusted copy of it for us to make it work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as that one is being deprecated and so results in a compiler warning.
Testing
I tested it locally by creating a copy of the file and including that one instead of the one from, this library. That was able to compile without deprecation warnings. Then ran the service with a local Pulsar standalone using Docker and was able to consume the JSON message that I sent in.