Skip to content

Fix SCA configurations (AST-85396) #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix SCA configurations (AST-85396) #1086

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b56043
Fix SCA configurations AST-85396
cx-alex-cohen Mar 27, 2025
1df6b83
Merge branch 'main' into bug/alex-fix-sca-configurations
cx-alex-cohen Apr 4, 2025
79b611b
Merge branch 'main' into bug/alex-fix-sca-configurations
cx-elchanan-arbiv Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/params/filters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ var BaseIncludeFilters = []string{
"Directory.Packages.props",
"*.rs",
"*.jsx",
"NuGet.Config",
".npmrc",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any other package manager's config files you guys want to add here?
can this change effect current customers?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now the other package manager config file that we need to add is settings.xml, but that one is already covered by the *.xml.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "affect current costumers"? In what way?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a way that it will include files that was not included in the past

}

var BaseExcludeFilters = []string{
Expand Down
Loading