Fix SCA configurations (AST-85396) #1086
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cx-alex-cohen
requested review from
cx-ben-alvo,
cx-daniel-greenspan and
cx-miryam-foifer
as code owners
|
Great job, no security vulnerabilities found in this Pull Request |
| @@ -137,6 +137,8 @@ var BaseIncludeFilters = []string{ | |||
| "Directory.Packages.props", | |||
| "*.rs", | |||
| "*.jsx", | |||
| "NuGet.Config", | |||
| ".npmrc", | |||
There was a problem hiding this comment.
are there any other package manager's config files you guys want to add here?
can this change effect current customers?
There was a problem hiding this comment.
For now the other package manager config file that we need to add is settings.xml, but that one is already covered by the *.xml.
There was a problem hiding this comment.
What do you mean by "affect current costumers"? In what way?
There was a problem hiding this comment.
in a way that it will include files that was not included in the past
|
Auto Comment from MCP |
cx-daniel-greenspan
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, you agree to the terms within the Checkmarx Code of Conduct. Please review the contributing guidelines for guidance on creating high-quality pull requests.
Description
Please provide a summary of the changes and the related issue. Include relevant motivation and context.
Type of Change
Related Issues
Link any related issues or tickets.
Checklist
Screenshots (if applicable)
Add screenshots to help explain your changes.
Additional Notes
Add any other relevant information.