Skip to content

FIX: #465: problem with Version handling in VSS to samm exporter #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

FIX: #465: problem with Version handling in VSS to samm exporter #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/vss_tools/exporters/samm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,19 +65,21 @@ def __get_version_vss(vss_tree: VSSNode) -> str:

if vss_version_node:
for v_child in vss_version_node.children:
# NOTE: Major, Minor and Patch Version fields are integers.
# There is a fourth Version field: Label, which is a string and currently is not handled.
if (
v_child.name in ["Major", "Minor", "Patch"]
and hasattr(v_child.data, "default")
and type(v_child.data.default) is int
and v_child.data.default > 1
):
match v_child.name:
case "Major":
major = v_child.data.default
case "Minor":
minor = v_child.data.default
case "Patch":
patch = v_child.data.default
if v_child.name == "Major" and v_child.data.default > major:
major = v_child.data.default

if v_child.name == "Minor" and v_child.data.default > minor:
minor = v_child.data.default

if v_child.name == "Patch" and v_child.data.default > patch:
patch = v_child.data.default

return f"{major}.{minor}.{patch}"

Expand Down