FIX: #465: problem with Version handling in VSS to samm exporter #466
+10
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kostadin Ivanov (BD/TBC-BG) <[email protected]>
Kostadin-Ivanov
force-pushed
the
fix/bug-in-get_version_vss
branch
from
a91173d to
614e5ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After done tests, I found that the problem was in __get_version_vss function.
Reworked function so it will make sure that it starts with default version: 1.0.0, then if VSS :: VersionVSS is provided and differs from the 1.0.0 it will get updated as per the VersionVSS default Major.Minor.Patch values, if these are higher than 1.0.0 respectively.