Skip to content

Remove V3 engine check #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

Remove V3 engine check #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21ebb8b
Remove V3 engine check
ag-ramachandran Nov 12, 2025
c89298a
* Bump minor version to 6.0.1
ag-ramachandran Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions connector/src/main/scala/com/microsoft/kusto/spark/utils/CslCommandsGenerator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,6 @@ private[kusto] object CslCommandsGenerator {
s""".show materialized-views | where SourceTable == '$destinationTableName' | count"""
}

def generateIsTableEngineV3(tableName: String): String = {
s""".show table ${tableName} details | project todynamic(ShardingPolicy).UseShardEngine"""
}

def generateTableMoveExtentsCommand(
sourceTableName: String,
destinationTableName: String,
Expand Down
21 changes: 8 additions & 13 deletions connector/src/main/scala/com/microsoft/kusto/spark/utils/ExtendedKustoClient.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import org.apache.log4j.Level
import org.apache.spark.sql.types.StructType

import java.time.{Duration, Instant, OffsetDateTime}
import java.util.{StringJoiner, UUID}
import java.util.{Objects, StringJoiner, UUID}
import scala.jdk.CollectionConverters._
import scala.concurrent.duration.FiniteDuration

Expand Down Expand Up @@ -538,18 +538,13 @@ class ExtendedKustoClient(
generateIsTableMaterializedViewSourceCommand(targetTable),
"isTableMV",
crp).getPrimaryResults
isDestinationTableMaterializedViewSourceResult.next()
val isDestinationTableMaterializedViewSource: Boolean =
isDestinationTableMaterializedViewSourceResult.getLong(0) > 0
if (isDestinationTableMaterializedViewSource) {
val res =
executeEngine(
database,
generateIsTableEngineV3(targetTable),
"isTableV3",
crp).getPrimaryResults
res.next()
res.getBoolean(0)
// Added a check just to be sure that
if (!Objects.isNull(isDestinationTableMaterializedViewSourceResult) &&
isDestinationTableMaterializedViewSourceResult.hasNext) {
isDestinationTableMaterializedViewSourceResult.next()
val isDestinationTableMaterializedViewSource: Boolean =
isDestinationTableMaterializedViewSourceResult.getLong(0) > 0
isDestinationTableMaterializedViewSource
} else {
false
}
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<version>${revision}</version>
<properties>
<!-- Compile-scoped dependency versions -->
<revision>7.0.0</revision>
<revision>7.0.1</revision>
<kusto.shade.prefix>kusto_connector_shaded</kusto.shade.prefix>
<azure.bom.version>1.3.2</azure.bom.version>
<azure.storage.version>8.6.6</azure.storage.version>
Expand Down