-
Notifications
You must be signed in to change notification settings - Fork 35
Remove V3 engine check #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request removes an unused Engine V3 check functionality and simplifies the materialized view source detection logic. The changes eliminate unnecessary code complexity by removing the V3 engine validation step that was previously performed after determining if a table is a materialized view source.
Key changes include:
- Removed the
generateIsTableEngineV3method fromCslCommandsGenerator - Simplified the materialized view source check logic in
ExtendedKustoClientto directly return the boolean result without additional Engine V3 validation - Added a null safety check with proper Objects import
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ExtendedKustoClient.scala | Simplified materialized view source detection by removing Engine V3 check and adding null safety |
| CslCommandsGenerator.scala | Removed unused generateIsTableEngineV3 method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
connector/src/main/scala/com/microsoft/kusto/spark/utils/ExtendedKustoClient.scala
Show resolved
Hide resolved
connector/src/main/scala/com/microsoft/kusto/spark/utils/ExtendedKustoClient.scala
Show resolved
Hide resolved
c6e9a74 to
04c8b75
Compare
565c8dc to
7d982e8
Compare
Fix conflicts
a246165 to
c89298a
Compare
This pull request primarily refactors how the system checks if a table is a materialized view source and removes an unused method for determining if a table uses Engine V3. The logic for checking if a table is a materialized view source is simplified, and unnecessary code is eliminated.
Key changes include:
Refactoring and Code Simplification
generateIsTableEngineV3method fromCslCommandsGeneratoras it is no longer used.ExtendedKustoClientfor checking if a table is a materialized view source by eliminating the Engine V3 check and directly returning the result.