Skip to content

Conversation

@ag-ramachandran
Copy link
Contributor

This pull request primarily refactors how the system checks if a table is a materialized view source and removes an unused method for determining if a table uses Engine V3. The logic for checking if a table is a materialized view source is simplified, and unnecessary code is eliminated.

Key changes include:

Refactoring and Code Simplification

  • Removed the generateIsTableEngineV3 method from CslCommandsGenerator as it is no longer used.
  • Simplified the logic in ExtendedKustoClient for checking if a table is a materialized view source by eliminating the Engine V3 check and directly returning the result.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes an unused Engine V3 check functionality and simplifies the materialized view source detection logic. The changes eliminate unnecessary code complexity by removing the V3 engine validation step that was previously performed after determining if a table is a materialized view source.

Key changes include:

  • Removed the generateIsTableEngineV3 method from CslCommandsGenerator
  • Simplified the materialized view source check logic in ExtendedKustoClient to directly return the boolean result without additional Engine V3 validation
  • Added a null safety check with proper Objects import

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
ExtendedKustoClient.scala Simplified materialized view source detection by removing Engine V3 check and adding null safety
CslCommandsGenerator.scala Removed unused generateIsTableEngineV3 method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Test Results

116 tests  ±0   116 ✅ ±0   17m 0s ⏱️ - 1m 7s
 24 suites ±0     0 💤 ±0 
 24 files   ±0     0 ❌ ±0 

Results for commit c89298a. ± Comparison against base commit ee8d1b1.

♻️ This comment has been updated with latest results.

@ag-ramachandran ag-ramachandran force-pushed the users/ramacg/bugfix/RemoveV3Check branch from c6e9a74 to 04c8b75 Compare October 27, 2025 07:42
@ag-ramachandran ag-ramachandran force-pushed the users/ramacg/bugfix/RemoveV3Check branch from 565c8dc to 7d982e8 Compare October 28, 2025 02:13
@ag-ramachandran ag-ramachandran merged commit 334894f into master Nov 12, 2025
4 checks passed
asaharn pushed a commit that referenced this pull request Nov 12, 2025
* Remove V3 engine check
ag-ramachandran pushed a commit that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants