-
Notifications
You must be signed in to change notification settings - Fork 62
Command Tool [AARD-2079]
#1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command Tool [AARD-2079]
#1274
Conversation
|
Waiting on pr #1268 to be merged in first, as that implements support for detecting if panels/modals are already opened |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Looks like typing in the search bar also drives robots around (WASD and arrow keys)
- I think whenever you reference a robot name, you should also reference the control scheme name (currently two dozers can't be distinguished)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Luna scheme conflicts with this binding. I would either make the triggering key rebindable or prevent inputs from using it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this concept overall and the use of fuse.js is very cool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, the command pallet without any border looks weird, when you have something other than the bottom part selected. If I make the boarder 1px dark grey, it adds a slight line, which separates the text box, making it more clear. Are you fine with the second option or do you still think the first is better? (@PepperLola) |
I like the last option best personally |
Autocomplete could sometimes get in the way, and be annoying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the separator but I think it would make sense either to have the border around the whole thing or just have a separator between the input and the options (only the top of the input), and maybe then get rid of the border radius on the top left and right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, but I think you should be able to scroll through all of them to see what options are available. It's true that you can filter some out so I guess it's not super important to include in this PR but I definitely think it would be worthwhile to add. EDIT: on second thought, I think it should be included in this PR as it's pretty core functionality and I think necessary for a good user experience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good. It would be nice if the scrolling were smooth, and there were a couple bugs I couldn't figure out how to consistently reproduce (sometimes it would always scroll the selected option to the second slot from the top, regardless of whether I was scrolling up or down). I think it's in a good state to be merged, keeping these fixes in mind for the future.
Task
Create a command tool, that allows synthesis users to type in "/" followed by a command that then executes a specific action.
AARD-2079
Symptom
It can get annoying for developers and users to have to go through multiple panels to achive what they want. For advanced users of Synthesis a command tool would let them quickly type commands to implement a specific action. For example, instead of having to go to debug tools, then clicking toggle drag mode, then clicking hide debug tools panel, you could just type "/drag mode" and it will toggle the drag mode.
Solution
Implement a simple Command palette that appears when pressing "/" and lists options of different commands. It uses an algorithm to determine what you are most likely typing and then suggesting that as an option. This means that both "/drag" or "/drqg" (typo example) will triggle the toggle drag mode command.
Verification
Before merging, ensure the following criteria are met: