Skip to content

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

  • Allows the user to type in Text Input examples by updating the Storybook arg appropriately. This is what people expect.
  • Updated the example values and a placeholder
  • Gave all inputs an appropriate size and added a bit to the prop’s documentation.

Why

Improves the examples for Text Input. After merging, I can update the other inputs as well.

How

n/a

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • n/a

@VincentSmedinga VincentSmedinga requested a review from a team as a code owner July 30, 2025 14:04
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the TextInput Storybook examples by making them interactive and more realistic. The changes allow users to type in the text input controls within Storybook and provide better example content.

  • Makes TextInput examples interactive by using controlled components with useArgs
  • Updates example values and placeholder text to be more realistic and localized
  • Improves the size prop documentation to provide clearer guidance

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
TextInput.stories.tsx Converts examples to controlled components, updates example values, and adds proper sizing
TextInput.docs.mdx Improves documentation for the size prop with clearer guidance

@github-actions github-actions bot temporarily deployed to demo-text-input-examples July 30, 2025 14:44 Destroyed
@Bondt007
Copy link

De inputs verwerken de tekst (te) traag, waardoor de tekst die ik tik niet geheel in de input komt te staan. Dat is jammer, en maakt dat het eruit ziet alsof het een beetje stuk is.

Wat eveneens opvalt is dat ik in de input ook foutieve waarden kan invoeren. De rode border van de validatie komt dan wel, maar natuurlijk niet de gehele foutmelding, want het gaat alleen om de text input en niet de hele samenstelling van meerdere componenten. Maar toch maakt dat het dat het wat 'on-af' aanvoelt, als gebruiker.

Om opmerkingen/vragen van anderen te voorkomen is het goed om te overwegen deze zo goed bedoelde feature terug te draaien/uit te zetten.

@github-actions github-actions bot temporarily deployed to demo-text-input-examples August 1, 2025 09:15 Destroyed
@github-actions github-actions bot temporarily deployed to demo-text-input-examples August 1, 2025 14:54 Destroyed
# Conflicts:
#	storybook/src/components/TextInput/TextInput.stories.tsx
@github-actions github-actions bot temporarily deployed to demo-text-input-examples August 1, 2025 15:03 Destroyed
@github-actions github-actions bot temporarily deployed to demo-text-input-examples September 11, 2025 09:37 Destroyed
@github-actions github-actions bot temporarily deployed to demo-text-input-examples September 11, 2025 09:46 Destroyed
@VincentSmedinga VincentSmedinga changed the title chore: Allow typing in Text Input examples and improve demo content chore: Improve demo content in Text Input examples Sep 11, 2025
@VincentSmedinga
Copy link
Contributor Author

Removed the ability to update the query in the addons panel – we can’t get the field to sync with the Input and vice versa.

@github-actions github-actions bot temporarily deployed to demo-text-input-examples September 19, 2025 14:07 Destroyed
@github-actions github-actions bot temporarily deployed to demo-text-input-examples September 26, 2025 18:00 Destroyed
@github-actions github-actions bot temporarily deployed to demo-text-input-examples September 30, 2025 12:50 Destroyed
@github-actions github-actions bot temporarily deployed to demo-text-input-examples October 3, 2025 08:44 Destroyed
@github-actions github-actions bot temporarily deployed to demo-text-input-examples October 8, 2025 11:49 Destroyed
@alimpens alimpens enabled auto-merge (squash) October 8, 2025 11:50
@alimpens alimpens merged commit d7dcc55 into develop Oct 8, 2025
7 checks passed
@alimpens alimpens deleted the chore/text-input-examples branch October 8, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants