-
Notifications
You must be signed in to change notification settings - Fork 10
chore: Improve demo content in Text Input examples #2157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the TextInput Storybook examples by making them interactive and more realistic. The changes allow users to type in the text input controls within Storybook and provide better example content.
- Makes TextInput examples interactive by using controlled components with
useArgs
- Updates example values and placeholder text to be more realistic and localized
- Improves the
size
prop documentation to provide clearer guidance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
TextInput.stories.tsx | Converts examples to controlled components, updates example values, and adds proper sizing |
TextInput.docs.mdx | Improves documentation for the size prop with clearer guidance |
De inputs verwerken de tekst (te) traag, waardoor de tekst die ik tik niet geheel in de input komt te staan. Dat is jammer, en maakt dat het eruit ziet alsof het een beetje stuk is. Wat eveneens opvalt is dat ik in de input ook foutieve waarden kan invoeren. De rode border van de validatie komt dan wel, maar natuurlijk niet de gehele foutmelding, want het gaat alleen om de text input en niet de hele samenstelling van meerdere componenten. Maar toch maakt dat het dat het wat 'on-af' aanvoelt, als gebruiker. Om opmerkingen/vragen van anderen te voorkomen is het goed om te overwegen deze zo goed bedoelde feature terug te draaien/uit te zetten. |
# Conflicts: # storybook/src/components/TextInput/TextInput.stories.tsx
# Conflicts: # storybook/src/components/TextInput/TextInput.stories.tsx
Removed the ability to update the query in the addons panel – we can’t get the field to sync with the Input and vice versa. |
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
Why
Improves the examples for Text Input. After merging, I can update the other inputs as well.
How
n/a
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes