Skip to content

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Aug 8, 2025

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

It adds some form page examples.

Why

To show how to set up form pages.

How

Typing

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Shouldn't withOneQuestion have an 'other' option? Do these 3 categories cover everything?
  • Does 'continue later' make sense for a form flow with 4-6 pages?
  • In the designs a Select is used. This is not recommended by gov.uk, because they are hard to use. I've used a Radio group here.
  • The design uses a Select for the country code when asking for a phone number. Gov.uk recommends not doing that, but simply allowing users to enter their phone number in a format that's familiar to them. If international numbers are an issue, they recommend adding a description.
  • The design uses a 'Previous'-button after the 'Next'-button. Gov.uk recommends placing a back link before the form. NLDS recommends aligning buttons to the start of the line. And Adam Silver explains why using multiple submit buttons in a form is a bad idea. So I've followed the gov.uk recommendation here.

@alimpens alimpens requested a review from a team as a code owner August 8, 2025 14:44
@alimpens alimpens marked this pull request as draft August 8, 2025 14:44
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples August 8, 2025 14:50 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples August 8, 2025 14:58 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples August 8, 2025 15:20 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples August 8, 2025 15:32 Destroyed
…into chore/DES-1358-add-form-page-examples
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples August 8, 2025 15:35 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples August 13, 2025 09:52 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples August 13, 2025 10:10 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples August 20, 2025 07:39 Destroyed
Copy link
Contributor

@dlnr dlnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a draft I won't go into the code, which looks fine, but I noticed the PageHeader is only showing the menu on the landingpage.

@alimpens
Copy link
Contributor Author

Since it's a draft I won't go into the code, which looks fine, but I noticed the PageHeader is only showing the menu on the landingpage.

Yeah, that's intentional

…into chore/DES-1358-add-form-page-examples
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples September 19, 2025 13:50 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples September 19, 2025 13:53 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples September 19, 2025 14:05 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples September 26, 2025 09:05 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples September 26, 2025 09:42 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples September 26, 2025 14:23 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples October 1, 2025 10:23 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples October 3, 2025 08:37 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples October 3, 2025 08:51 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples October 3, 2025 09:10 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples October 3, 2025 10:40 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples October 8, 2025 11:28 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples October 8, 2025 11:44 Destroyed
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. So much intricacies here, but the examples are still clearly structured, well-documented, and, of course, a joy to use :)

@github-actions github-actions bot temporarily deployed to demo-DES-1358-add-form-page-examples October 8, 2025 11:56 Destroyed
@VincentSmedinga VincentSmedinga enabled auto-merge (squash) October 8, 2025 11:56
@VincentSmedinga VincentSmedinga merged commit 63beb33 into develop Oct 8, 2025
7 checks passed
@VincentSmedinga VincentSmedinga deleted the chore/DES-1358-add-form-page-examples branch October 8, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants