-
Notifications
You must be signed in to change notification settings - Fork 10
chore: Add form page examples #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add form page examples #2172
Conversation
…b.com/Amsterdam/design-system into chore/DES-1358-add-form-page-examples
…into chore/DES-1358-add-form-page-examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's a draft I won't go into the code, which looks fine, but I noticed the PageHeader is only showing the menu on the landingpage.
Yeah, that's intentional |
…into chore/DES-1358-add-form-page-examples
…o chore/DES-1358-add-form-page-examples
…into chore/DES-1358-add-form-page-examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. So much intricacies here, but the examples are still clearly structured, well-documented, and, of course, a joy to use :)
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
It adds some form page examples.
Why
To show how to set up form pages.
How
Typing
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes
Shouldn'twithOneQuestion
have an 'other' option? Do these 3 categories cover everything?Does 'continue later' make sense for a form flow with 4-6 pages?In the designs a Select is used. This is not recommended by gov.uk, because they are hard to use. I've used a Radio group here.