Skip to content

Create pull_request_template.md #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Create pull_request_template.md #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ddfaa5
Create pull_request_template.md
TheFlameFish May 9, 2025
a1930de
Spotless
TheFlameFish May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{Description of the PR}

Issues this may resolve (delete line if none):

TODO:
- [ ] Perform basic functions test on production robot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is checking the boxes? I would propose the reviewer either does the test themselves (ideal) or watches the developer do the test.

- [ ] Test PR feature(s) on production robot
- [ ] Perform basic functions test on prototype robot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel performing tests on two robots is a bit much per PR and slows things down. I think just testing on production robot is fine, and I would be ok risking a regression on the prototype bot to speed things along. I'm a bit on the fence still though.

- [ ] Test PR feature(s) on prototype robot