Create pull_request_template.md #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheFlameFish
requested review from
nolanhergert,
christianbryant,
Spades-of-Aces,
DustinTrumps,
Ace5tar,
notpro-ek and
goober48
|
Out of curiosity, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
| TODO: | ||
| - [ ] Perform basic functions test on production robot | ||
| - [ ] Test PR feature(s) on production robot | ||
| - [ ] Perform basic functions test on prototype robot |
There was a problem hiding this comment.
I feel performing tests on two robots is a bit much per PR and slows things down. I think just testing on production robot is fine, and I would be ok risking a regression on the prototype bot to speed things along. I'm a bit on the fence still though.
| Issues this may resolve (delete line if none): | ||
|
|
||
| TODO: | ||
| - [ ] Perform basic functions test on production robot |
There was a problem hiding this comment.
Who is checking the boxes? I would propose the reviewer either does the test themselves (ideal) or watches the developer do the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a PR template for consistent structuring and include important TODOs by default