Choreo accuracy & improved mobility autos #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * terminate the command. | ||
| * @return A command to drive to the target pose, terminating once at acceptable error. | ||
| */ | ||
| public static Command simpleGoToPoint(Drive drive, Pose2d target) { |
There was a problem hiding this comment.
From how far away did you test this PID-only pathing, and what did it behave like? It seems like it was good, or else you wouldn't recommend it. I can watch tomorrow too.
There was a problem hiding this comment.
Tested from about 2.7178 m and 180 degrees. Seems decently smooth, although a bit slow
Ace5tar
previously approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give Choreo real robot numbers, lengthen mobility autos as requested by strategy, minor refactor of choreo trajectories, and use exclusively PID for driver assist
TODO: