-
Notifications
You must be signed in to change notification settings - Fork 78
Improve resource allocation choice generator #6313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2i2c-org#6309, we discovered that some of our resource allocations were now outdated. This adds a 2% wiggle room that should help with that
Otherwise we were losing a lot of resources on large nodes
Based on 2i2c-org#6351 (comment) 1. Much more limited use of fractions - only for CPUs under 2. No fractions over that, everything is rounded to nearest whole number 2. The display name indicates how much CPU is guaranteed 3. The description indicates CPU limits with appropriate wording 4. Allow specifying multiple node types in one go, makes copy pasting easier. 5. No longer specify 'default: true', as first one is default now
daab30e
to
ceedd54
Compare
for more information, see https://pre-commit.ci
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
Jul 15, 2025
Based on conversation in 2i2c-org#6351 Regenerated based on 2i2c-org#6313
Merging this PR will trigger the following deployment actions. Support deploymentsNo support upgrades will be triggered Staging deployments
Production deployments
|
@yuvipanda, I know that this could be improved/documented as part of #6213, BUT since it looks we haven't had time to commit it these past sprints, can we merge this PR as it is so we can use it more easily? |
7 tasks
agoose77
added a commit
that referenced
this pull request
Aug 6, 2025
agoose77
added a commit
that referenced
this pull request
Aug 6, 2025
* docs: improve deployment information * feat: add new hub * Update config/clusters/berkeley-geojupyter/cluster.yaml * feat: use resource allocation from #6313
Fair enough, @GeorgianaElena - merged. |
jnywong
pushed a commit
to jnywong/infrastructure
that referenced
this pull request
Aug 7, 2025
* docs: improve deployment information * feat: add new hub * Update config/clusters/berkeley-geojupyter/cluster.yaml * feat: use resource allocation from 2i2c-org#6313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.