Skip to content

RdmaServerEndpoint accept may return null, if listening endpoint closes. #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RdmaServerEndpoint accept may return null, if listening endpoint closes. #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/com/ibm/disni/RdmaServerEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,12 @@ public C accept() throws IOException {
}
}
C endpoint = requested.poll();
logger.info("connect request received");
endpoint.accept();

// a null endpoint gets returned if listening endpoint closes
if (endpoint != null) {
logger.info("connect request received");
endpoint.accept();
}
return endpoint;
Copy link
Contributor

@PepperJo PepperJo Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure applications are handling the case correctly if null is returned here? Might as well throw an exception (Much like before)?

} catch (Exception e) {
throw new IOException(e);
Expand Down