-
Notifications
You must be signed in to change notification settings - Fork 0
Allow usage with Rails 3 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* lower `rails` version dependency from 4.2 to 3.2 * skip `CheckPending.class_eval` unless Rails version is >= 4
Looks good-ish. This lib has no tests though. Could you give me a bit more context into this? It's called What apps are using this lib? |
@kurko AR code in Rails doesn't require an app to even start successfully. We want to be able to start our apps even in the absence of the database, and then respond to endpoints which do not require DB access successfully. Primarily this is typically our If you actually try to execute any endpoints or other codepaths that require DB access you should still get an exception. |
@kurko @mecampbellsoup we should put this in the readme maybe? Associated rails issue -> rails/rails#22154 |
That makes sense. |
@mecampbellsoup while i have no idea how to add the rails tests we could easily add dummy apps for the supported rails versions to confirm this is working from the user's perspective |
@mecampbellsoup also you can run the zipmark-service tests with this branch included to make sure it doesnt break anything |
@jakehow as, say, fixtures at Should it be a rake task or something, e.g. |
Current Behavior
Does not work with Rails 3 due to
gemspec
versioning of therails
dependency.Why Change?
We'd like to use this gem within
zipmark-service
which is a Rails 3 application.Implementation
rails
version dependency from 4.2 to 3.2 in thegemspec
ActiveRecord::Migration::CheckPending.class_eval
block if Rails version is >= 4