Skip to content

Conversation

@candeodevelopment
Copy link
Contributor

Proposed change

Adds support for Candeo SR5BR 5-button remote with rotating dial.

Additional information

@TheJulianJES we added a few new consts to const.py to support this device:

BUTTON_CENTRE = "button_centre"
STOPPED_ROTATING_WITH_DIRECTION = "rotary_knob_stopped_rotating_with_direction"

Would you be able to add these translation strings to HA's ZHA integration when you get a chance please?

"trigger_type": {
    "rotary_knob_stopped_rotating_with_direction": "Rotary knob stopped rotating \"{subtype}\"",
}

"trigger_subtype": {
    "button_centre": "Centre Button",
}

If possible please could you also give us some pointers on which (if any) unit tests would be needed for this PR?

Device diagnostics

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 54.76190% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.98%. Comparing base (928268c) to head (69f472e).

Files with missing lines Patch % Lines
...irks/candeo/scene_switch_remote_5_button_rotary.py 53.65% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4470      +/-   ##
==========================================
- Coverage   92.24%   91.98%   -0.26%     
==========================================
  Files         369      370       +1     
  Lines       12094    12178      +84     
==========================================
+ Hits        11156    11202      +46     
- Misses        938      976      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant