Fix approve state detection #849
Open
+43
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 build.zip [updated at Sep 16, 3:45:19 PM UTC] |
| if (hash) { | ||
| const tx = transactions.find((tx) => tx.hash === hash); | ||
| return tx ? getTransactionObjectStatus(tx) : null; | ||
| return tx ? getTransactionObjectStatus(tx) : 'pending'; |
There was a problem hiding this comment.
Do you think this is correct? Can there be a problem where "pending" a wrong label to show/use?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a broken state when approval tx is confirmed and we are fetching new quotes, the submit button had 'Approve' title.
This happened because we kept the previous "approval" quote while fetching new one.
So I added a check that there is no quote loading at the moment to show 'Approve' title.