Skip to content

Add missing dockerignore #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2025
Merged

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented May 17, 2025

Summary

  • Add .dockerignore files for projects with Dockerfiles to improve build performance and security by excluding unnecessary files from Docker context
  • Added for bank_subscription_prediction, huggingface-sagemaker/gradio, magic-photobooth, nightwatch-ai, retail-forecast, and zenml-support-agent

Testing

  • Verified all projects with Dockerfiles now have corresponding .dockerignore files

Copy link

dagshub bot commented May 17, 2025

@strickvl strickvl requested a review from Copilot May 17, 2025 16:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds missing .dockerignore files to multiple projects to ensure that unwanted files such as version control metadata, Python caches, build artifacts, testing reports, and IDE-specific files are excluded from Docker builds.

  • Added standardized .dockerignore across six different project directories.
  • Ensured consistency in ignoring patterns for common artifacts and temporary files.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
zenml-support-agent/.dockerignore Added .dockerignore file with patterns to ignore unnecessary files.
retail-forecast/.dockerignore Added .dockerignore file with patterns to ignore unnecessary files.
nightwatch-ai/.dockerignore Added .dockerignore file with patterns to ignore unnecessary files.
magic-photobooth/.dockerignore Added .dockerignore file with patterns to ignore unnecessary files.
huggingface-sagemaker/gradio/.dockerignore Added .dockerignore file with patterns to ignore unnecessary files.
bank_subscription_prediction/.dockerignore Added .dockerignore file with patterns to ignore unnecessary files.

@strickvl strickvl requested a review from safoinme May 17, 2025 16:26
@strickvl strickvl merged commit 54dbfa0 into main May 17, 2025
4 of 5 checks passed
@strickvl strickvl deleted the codex/create-dockerignore-files-for-repos branch May 17, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants