Skip to content

Add padding to icon for visual balance, add screenshots and brand colors to Flathub #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

TylerLaBree
Copy link

Flathub guidelines suggest that app icons should have padding to help them fit with other app icons.

There's also an issue on the main repo discussing this change.

In this pull request, I simply change the viewBox of the svg from "0 0 1024 1024" to "-96 -96 1216 1216", to follow these guidelines.

@TylerLaBree
Copy link
Author

TylerLaBree commented Feb 20, 2025

I'm not super familiar with the nuances of Github, so I meant to make these into two pull requests. If you think you'd like to accept one and not the other, I'd be happy to split them up.

The second change is to add screenshots and brand colors to the Flathub listing. Here's a preview of what that would look like.

image

@TylerLaBree TylerLaBree changed the title Add padding to icon for visual balance Add padding to icon for visual balance, add screenshots and brand colors to Flathub Feb 20, 2025
@cassidyjames
Copy link

cassidyjames commented Feb 25, 2025

There's also a discussion I opened at zen-browser/desktop#2646, though that was before the more recent branding refresh I guess.

I would recommend against the matching background color for the dark icon, as that will likely fail the quality check for Flathub (since the icon kind of gets lost there). I'd recommend a slightly lighter color for the dark banner anyway, as the current color could blend too much with the dark background of Flathub and other app store clients.

Here's an example:

<branding>
  <color type="primary" scheme_preference="light">#f2f0e3</color>
  <color type="primary" scheme_preference="dark">#2e2e2e</color>
</branding>

Screenshot 2025-02-25 at 16-28-20 Brand color preview Flathub Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants