Simplify lifetimes #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
simplify-lifetimes
branch
from
4ee3e76 to
3247313
Compare
Twey
force-pushed
the
simplify-lifetimes
branch
2 times, most recently
from
19134e1 to
c4d04d2
Compare
Since `&'a mut R` is `Read` (or `Write`) when `R` is `Read` (resp. `Write`), there is no need to depend on `<R: ?Sized + Read> &'a mut R` over just plain `<R: Read> R`. The caller can still instantiate `R = &'a mut R_` when a reference is desired (and indeed this is done here for e.g. `MapDeserializer`).
ma2bd
reviewed
Jun 12, 2025
src/ser.rs
Outdated
Comment on lines
4
to
7
| // `Error::other` doesn't exist on the MSRV. | ||
| #![allow(clippy::io_other_error)] | ||
| // And neither does `clippy::io_other_error`. | ||
| #![allow(unknown-lints)] |
There was a problem hiding this comment.
This doesn't work. Should we just bump the MSRV?
There was a problem hiding this comment.
Oh I think I just misnamed the lint. Fixed in a2260bf.
We could, but in order to get std::io::Error::other we'd need to bump to 1.74, which is a pretty major bump. I'm okay with it if yous are, but it's not a decision I'd take by myself. OTOH it will steadily become harder to maintain lint compatibility between 1.56 and current Rust.
ma2bd
reviewed
Jun 12, 2025
src/ser.rs
Outdated
| } | ||
|
|
||
| impl<'a, W> ser::Serializer for Serializer<'a, W> | ||
| impl<'r, W> ser::Serializer for Serializer<&'r mut W> |
There was a problem hiding this comment.
why 'r ? The rest of the file uses 'a consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the lifetimes used in the
SerializerandDeserializerstructs. Previous behaviour remains by instantiatingR = &mut R_.Also fixes a few new Clippy lints.