-
Notifications
You must be signed in to change notification settings - Fork 6k
languages: Fix indentation for if/else statements in C/C++ without braces #41670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey! I was also working on this today, but forgot to comment on the issue, so no worries at all. I would just like to point out that this applies to C++ as well (as the original example showed). Also, feel free to let me know if there was an error in what I was doing, but I ended up solving this by just modifying this:
To be: (for both C & C++), thus not needing to modify Thoughts? |
|
Hey @teowelton, I tested your way and it works great, thanks! I've also updated this PR as it requires minimal changes that way.
Yeah, I was hoping to create a separate PR for C++ but maybe you can do that? |
acfe96a to
62d8209
Compare
I think that in this case having both in the same PR is much cleaner, since they fall under the same issue. The solution is the same too, simply modifying the
|
|
@teowelton makes sense |
a395bca to
143c16c
Compare
Closes #41179
Release Notes: