Skip to content

Add oldbook-theme extension #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 30, 2025
Merged

Conversation

gko
Copy link
Contributor

@gko gko commented Jul 26, 2025

No description provided.

This comment was marked as resolved.

@gko

This comment was marked as resolved.

@cla-bot cla-bot bot added the cla-signed label Jul 26, 2025

This comment was marked as resolved.

@maxdeviant maxdeviant changed the title add oldbook-theme Add oldbook-theme extension Jul 27, 2025
@gko
Copy link
Contributor Author

gko commented Jul 30, 2025

@maxdeviant I might be wrong but I think that CI is failing because of #3079:

Error: Command failed: ./zed-extension --scratch-dir ./scratch --source-dir extensions/nyxvamp-theme --output-dir output
[2025-07-29T21:27:47Z INFO  zed_extension] loading extension manifest
[2025-07-29T21:27:47Z INFO  zed_extension] compiling extension
[2025-07-29T21:27:47Z INFO  extension::extension_builder] finished compiling extension /home/runner/work/extensions/extensions/extensions/nyxvamp-theme
[2025-07-29T21:27:47Z WARN  theme] Theme "NyxVamp Veil" is using a deprecated style property: scrollbar_thumb.background. Use `scrollbar.thumb.background` instead.
[2025-07-29T21:27:47Z WARN  theme] Theme "NyxVamp Obsidian" is using a deprecated style property: scrollbar_thumb.background. Use `scrollbar.thumb.background` instead.
[2025-07-29T21:27:47Z WARN  theme] Theme "NyxVamp Radiance" is using a deprecated style property: scrollbar_thumb.background. Use `scrollbar.thumb.background` instead.
[2025-07-29T21:27:47Z INFO  zed_extension] loaded theme family NyxVamp
Error: Theme "NyxVamp Veil" is using a deprecated style property: scrollbar_thumb.background. Use `scrollbar.thumb.background` instead.

    at genericNodeError (node:internal/errors:984:15)
    at wrappedFn (node:internal/errors:538:14)
    at ChildProcess.exithandler (node:child_process:422:12)
    at ChildProcess.emit (node:events:524:28)
    at maybeClose (node:internal/child_process:1104:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5) {
  code: 1,
  killed: false,
  signal: null,
  cmd: './zed-extension --scratch-dir ./scratch --source-dir extensions/nyxvamp-theme --output-dir output'
}

Node.js v20.19.4
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

@maxdeviant
Copy link
Member

@maxdeviant I might be wrong but I think that CI is failing because of #3079:

Error: Command failed: ./zed-extension --scratch-dir ./scratch --source-dir extensions/nyxvamp-theme --output-dir output
[2025-07-29T21:27:47Z INFO  zed_extension] loading extension manifest
[2025-07-29T21:27:47Z INFO  zed_extension] compiling extension
[2025-07-29T21:27:47Z INFO  extension::extension_builder] finished compiling extension /home/runner/work/extensions/extensions/extensions/nyxvamp-theme
[2025-07-29T21:27:47Z WARN  theme] Theme "NyxVamp Veil" is using a deprecated style property: scrollbar_thumb.background. Use `scrollbar.thumb.background` instead.
[2025-07-29T21:27:47Z WARN  theme] Theme "NyxVamp Obsidian" is using a deprecated style property: scrollbar_thumb.background. Use `scrollbar.thumb.background` instead.
[2025-07-29T21:27:47Z WARN  theme] Theme "NyxVamp Radiance" is using a deprecated style property: scrollbar_thumb.background. Use `scrollbar.thumb.background` instead.
[2025-07-29T21:27:47Z INFO  zed_extension] loaded theme family NyxVamp
Error: Theme "NyxVamp Veil" is using a deprecated style property: scrollbar_thumb.background. Use `scrollbar.thumb.background` instead.

    at genericNodeError (node:internal/errors:984:15)
    at wrappedFn (node:internal/errors:538:14)
    at ChildProcess.exithandler (node:child_process:422:12)
    at ChildProcess.emit (node:events:524:28)
    at maybeClose (node:internal/child_process:1104:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5) {
  code: 1,
  killed: false,
  signal: null,
  cmd: './zed-extension --scratch-dir ./scratch --source-dir extensions/nyxvamp-theme --output-dir output'
}

Node.js v20.19.4
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

This branch needed to be updated with main.

Now it looks like it is failing over some missing metadata.

@gko gko force-pushed the add-oldbook-theme branch from 0b81097 to 1bc4b2a Compare July 30, 2025 21:32
@gko
Copy link
Contributor Author

gko commented Jul 30, 2025

@maxdeviant seems like CI was trying to validate vscode theme as well, so I moved it to a separate folder

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maxdeviant maxdeviant merged commit da21a27 into zed-industries:main Jul 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants