Skip to content

Add devsense-php-ls LSP support #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions extension.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ schema_version = 1
authors = ["Piotr Osiewicz <[email protected]>"]
repository = "https://github.com/zed-extensions/php"

[language_servers.phptools]
name = "PhpTools"
language = "PHP"
language_ids = { PHP = "php" }

[language_servers.intelephense]
name = "Intelephense"
language = "PHP"
Expand Down
2 changes: 2 additions & 0 deletions src/language_servers.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
mod phptools;
mod intelephense;
mod phpactor;

pub use phptools::*;
pub use intelephense::*;
pub use phpactor::*;
130 changes: 130 additions & 0 deletions src/language_servers/phptools.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
use std::fs;
use zed::{Architecture, Os};
use zed_extension_api::settings::LspSettings;
use zed_extension_api::{self as zed, serde_json, LanguageServerId, Result};

const PACKAGE_NAME: &str = "devsense-php-ls";

pub struct PhpTools {
did_find_server: bool,
}

impl PhpTools {
pub const LANGUAGE_SERVER_ID: &'static str = "phptools";

pub fn new() -> Self {
Self {
did_find_server: false,
}
}

pub fn language_server_command(
&mut self,
language_server_id: &LanguageServerId,
worktree: &zed::Worktree,
) -> Result<zed::Command> {
if let Some(path) = worktree.which("phptools") {
return Ok(zed::Command {
command: path,
args: vec!["--stdio".to_string()],
env: Default::default(),
});
}

let server_path = self.server_script_path(language_server_id)?;
Ok(zed::Command {
command: server_path,
args: vec![
//"--debug".to_string(),
//"--attach".to_string(),
"--composerNodes".to_string(),
"false".to_string(), // disable /vendor/ caching
],
env: Default::default(),
})
}

fn server_file_path(&self) -> std::string::String {
let (os, arch) = zed::current_platform();

let os_str = match os {
Os::Mac => "darwin",
Os::Linux => "linux",
Os::Windows => "win32",
};

let arch_str = match arch {
Architecture::Aarch64 => "arm64",
Architecture::X86 | Architecture::X8664 => "x64",
};

let ext_str = match os {
Os::Windows => ".exe",
_ => "",
};
//
format!(
"node_modules/devsense-php-ls-{0}-{1}/dist/devsense.php.ls{2}",
os_str, arch_str, ext_str
)
}

fn server_exists(&self) -> bool {
fs::metadata(self.server_file_path()).map_or(false, |stat| stat.is_file())
}

fn server_script_path(&mut self, language_server_id: &LanguageServerId) -> Result<String> {
let server_exists = self.server_exists();
let server_path = self.server_file_path();
if self.did_find_server && server_exists {
return Ok(server_path);
}

zed::set_language_server_installation_status(
language_server_id,
&zed::LanguageServerInstallationStatus::CheckingForUpdate,
);
let version = zed::npm_package_latest_version(PACKAGE_NAME)?;

if !server_exists
|| zed::npm_package_installed_version(PACKAGE_NAME)?.as_ref() != Some(&version)
{
zed::set_language_server_installation_status(
language_server_id,
&zed::LanguageServerInstallationStatus::Downloading,
);
let result = zed::npm_install_package(PACKAGE_NAME, &version);
match result {
Ok(()) => {
if !self.server_exists() {
Err(format!(
"installed package '{PACKAGE_NAME}' did not contain expected path '{server_path}'",
))?;
}
}
Err(error) => {
if !self.server_exists() {
Err(error)?;
}
}
}
}

self.did_find_server = true;
Ok(server_path)
}

pub fn language_server_workspace_configuration(
&mut self,
worktree: &zed::Worktree,
) -> Result<Option<serde_json::Value>> {
let settings = LspSettings::for_worktree("phptools", worktree)
.ok()
.and_then(|lsp_settings| lsp_settings.settings.clone())
.unwrap_or_default();

Ok(Some(serde_json::json!({
"phptools": settings
})))
}
}
13 changes: 12 additions & 1 deletion src/php.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,18 @@ mod language_servers;
use zed::CodeLabel;
use zed_extension_api::{self as zed, serde_json, LanguageServerId, Result};

use crate::language_servers::{Intelephense, Phpactor};
use crate::language_servers::{PhpTools, Intelephense, Phpactor};

struct PhpExtension {
phptools: Option<PhpTools>,
intelephense: Option<Intelephense>,
phpactor: Option<Phpactor>,
}

impl zed::Extension for PhpExtension {
fn new() -> Self {
Self {
phptools: None,
intelephense: None,
phpactor: None,
}
Expand All @@ -24,6 +26,10 @@ impl zed::Extension for PhpExtension {
worktree: &zed::Worktree,
) -> Result<zed::Command> {
match language_server_id.as_ref() {
PhpTools::LANGUAGE_SERVER_ID => {
let phptools = self.phptools.get_or_insert_with(PhpTools::new);
phptools.language_server_command(language_server_id, worktree)
}
Intelephense::LANGUAGE_SERVER_ID => {
let intelephense = self.intelephense.get_or_insert_with(Intelephense::new);
intelephense.language_server_command(language_server_id, worktree)
Expand All @@ -46,6 +52,11 @@ impl zed::Extension for PhpExtension {
language_server_id: &LanguageServerId,
worktree: &zed::Worktree,
) -> Result<Option<serde_json::Value>> {
if language_server_id.as_ref() == PhpTools::LANGUAGE_SERVER_ID {
if let Some(phptools) = self.phptools.as_mut() {
return phptools.language_server_workspace_configuration(worktree);
}
}
if language_server_id.as_ref() == Intelephense::LANGUAGE_SERVER_ID {
if let Some(intelephense) = self.intelephense.as_mut() {
return intelephense.language_server_workspace_configuration(worktree);
Expand Down