feat(values): add schema validation #4252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kit Patella <[email protected]>
…flags to package create,deploy and inspect cmds with --set Signed-off-by: Kit Patella <[email protected]>
…options Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…tion Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…m chart value overrides Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…n using zarf to helm values mappings Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…than i expected Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
mkcp
changed the title
Signed-off-by: Kit Patella <[email protected]>
Resolved merge conflicts across multiple files: - src/api/v1alpha1/package.go: Updated schema comment - src/api/v1alpha1/component.go: Kept jsonschema patterns - src/internal/template/template.go: Used main's security improvements - src/internal/feature/feature.go: Merged RegistryProxy and Values features - src/internal/value/value.go: Added schema validation support - src/cmd/package.go: Merged deploy options and values parsing - src/pkg/packager/actions/actions.go: Merged template check and setValue handling - src/pkg/packager/deploy.go: Added schema validation and ValuesDir paths - src/pkg/packager/layout/assemble.go: Updated cosign v3, added schema file copying - zarf.schema.json: Accepted main's version (to be regenerated) Schema validation features preserved: - Values.Validate() method with JSON schema support - SchemaValidationError type - Schema file copying during package assembly - Values directory structure support
Signed-off-by: Kit Patella <[email protected]>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…logs in e2e Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
AustinAbro321
requested changes
Nov 4, 2025
Member
AustinAbro321
left a comment
AustinAbro321
left a comment
There was a problem hiding this comment.
Mainly a question of create vs deploy "required" enforcement
Signed-off-by: Kit Patella <[email protected]>
…-time Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for json schema validation of values both at create and deploy time.
More tangetially, it also adds in a schema check on the v1alpha1 struct for ZarfChartValue mappings, ensuring they start with a
., are provided as.segmented sections, and are all valid characters for use in a golang string map.Once #4268 is ready, I think it would make sense to do a schema validate there as well. Remove doesn't have access to the package value schema contents yet so adding it to remove would be more a of future concern.
Related Issue
Fixes #4225
Relates to #3946
Checklist before merging