feat(prune): add support for removing charts not tracked in state

[brandtkeller]

Description

Adds support for a zarf package prune command. This allows for the explicit removal of a component chart by name OR it can look for all pending/orphaned resources and provide a list. Requires confirmation.

Related Issue

Fixes #2992

Checklist before merging

• Test, docs, adr added or updated as needed
• Contributor Guide Steps followed

[netlify]

✅ Deploy Preview for zarf-docs canceled.

Name	Link
🔨 Latest commit	4530168
🔍 Latest deploy log	https://app.netlify.com/projects/zarf-docs/deploys/68f91dd9a604030007be48ef

[codecov]

Codecov Report

❌ Patch coverage is 38.46154% with 112 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/cmd/package.go	21.35%	81 Missing ⚠️
src/pkg/packager/prune.go	0.00%	16 Missing ⚠️
src/pkg/packager/deploy.go	0.00%	15 Missing ⚠️

Files with missing lines	Coverage Δ
src/pkg/state/state.go	42.96% <100.00%> (+12.33%)	⬆️
src/pkg/packager/deploy.go	0.00% <0.00%> (ø)
src/pkg/packager/prune.go	0.00% <0.00%> (ø)
src/cmd/package.go	39.03% <21.35%> (-1.50%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[AustinAbro321]

Main comment is around prune when entire components are removed. Great start, I think this will be a nice value add

[AustinAbro321]

Charts are set to orphaned only work when a chart is removed from a component, but not when a component is removed entirely. I believe this could confuse some users. This could also encourage users to add all their charts to a single component so they can use prune in the future if need be.

[brandtkeller]

Could you elaborate more? is this a concern or a required change?

Charts should only be able to be orphaned during deploys. Removes should remove all charts - active or orphaned. I do see room for confusion among the two commands but less of a distinct path forward.

[AustinAbro321]

Ah there's a misunderstanding. I mean when a component is removed from one package to another, rather than it being removed with zarf package remove.

For example, if we started with components like so

components:
  - name: test-component
    required: true
    charts:
      - name: chart-to-keep
        version: 1.0.0
        namespace: prune-test
        localPath: chart-to-keep
  - name: test-component-2
    charts:
      - name: chart-to-remove
        version: 1.0.0
        namespace: prune-test
        localPath: chart-to-remove

then in the next version of the package removed test-component-2. Functionally, I think as a user I'd expect prune to behave the same in both situations, but currently it will only track the chart if it was originally in a component that still exists. In my experience, more often than not a component has a single chart.

[brandtkeller]

Ah interesting - correct me if I understood wrong - not only does Zarf orphan InstalledCharts from state - it also orphans components from state as well?

[AustinAbro321]

Yea, when Zarf records a package deployment it overwrites the existing secret and only the components that were in the latest deployment are added to state.