Skip to content

Conversation

@a1994sc
Copy link
Contributor

@a1994sc a1994sc commented Sep 14, 2025

Description

When the Zarf init package is not empty or when named init, this PR will now include that name in the pulled down tar ball.

Related Issue

Fixes #4095

Checklist before merging

@a1994sc a1994sc requested review from a team as code owners September 14, 2025 16:08
@netlify
Copy link

netlify bot commented Sep 14, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit b0c17c6
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68c6eb620146a80008b42c06

@a1994sc a1994sc force-pushed the feature/4095_custom_names_in_tar branch from d2466ad to b0c17c6 Compare September 14, 2025 16:20
@AustinAbro321
Copy link
Member

Hmm I don't love special casing the default init package, but I do agree that currently it's not good behavior that name changing the init package doesn't affect the package name. Another option could be removing the specialness from the init package in general and naming it zarf-package-init like every other package. This is a bigger breaking change since no doubt many users have shell scripts that pick up the init package. I think the initial naming convention was designed without custom init packages in mind.

What do the other @zarf-dev/maintainers think?

@brandtkeller brandtkeller moved this to In progress in Zarf Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

Allow the custom name of init packages, that are not name init, in the locally pull tar-ball

2 participants