pscanrules: PII Disclosure threshold handling and visible text #6804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
kingthorin
force-pushed
the
pii-fps
branch
3 times, most recently
from
0aa3ba3 to
cfbf4aa
Compare
|
Note the diff probably seems like a lot of change but part of that is because an extra loop was introduced which changed indentation on a bunch of lines, and another block of code was moved earlier in the file. |
thc202
reviewed
Oct 15, 2025
addOns/pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/PiiScanRule.java
Outdated
Show resolved
Hide resolved
addOns/pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/PiiScanRule.java
Outdated
Show resolved
Hide resolved
addOns/pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/PiiScanRule.java
Outdated
Show resolved
Hide resolved
...c/main/javahelp/org/zaproxy/zap/extension/pscanrules/resources/help/contents/pscanrules.html
Outdated
Show resolved
Hide resolved
addOns/pscanrules/src/test/java/org/zaproxy/zap/extension/pscanrules/PiiScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
addOns/pscanrules/src/test/java/org/zaproxy/zap/extension/pscanrules/PiiScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
addOns/pscanrules/src/test/java/org/zaproxy/zap/extension/pscanrules/PiiScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
addOns/pscanrules/src/test/java/org/zaproxy/zap/extension/pscanrules/PiiScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
pii-fps
branch
4 times, most recently
from
e8b6f05 to
2e6ee57
Compare
Signed-off-by: kingthorin <[email protected]>
|
Got all those (I think) and the conflict. |
thc202
approved these changes
Oct 16, 2025
|
Thank you! |
psiinon
approved these changes
Oct 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The PII Disclosure scan rule now only evaluates visible text and script blocks at Medium or High alert threshold, while the entire response body is considered at Low alert threshold.
This is intended to reduce false positives related to values present in non-visible HTML elements such as attributes, etc.