Reduce use of error level logging in pscan rules, tech detection, & retire #6645
Conversation
| public void scanHttpResponseReceive(HttpMessage msg, int id, Source source) { | ||
|
|
||
| try { | ||
| LOGGER.debug( |
There was a problem hiding this comment.
This looks like a lot but it's because all the indentation changed.
There was a problem hiding this comment.
It is likely helpful to "Hide Whitespace" while reviewing this PR.
| @Override | ||
| public void scanHttpResponseReceive(HttpMessage msg, int id, Source source) { | ||
|
|
||
| try { |
There was a problem hiding this comment.
This looks like a lot but it's because all the indentation changed.
| public void scanHttpResponseReceive(HttpMessage msg, int id, Source source) { | ||
|
|
||
| // TODO: standardise the logic in the case of duplicate / conflicting headers. | ||
| try { |
There was a problem hiding this comment.
This looks like a lot but it's because all the indentation changed.
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
kingthorin
force-pushed
the
pscan-dont-log-at-error
branch
from
77572e5 to
518f493
Compare
kingthorin
force-pushed
the
pscan-dont-log-at-error
branch
2 times, most recently
from
0c65c0c to
fe7bda8
Compare
kingthorin
force-pushed
the
pscan-dont-log-at-error
branch
from
fe7bda8 to
e17fe64
Compare
|
I've re-run CI twice (so it's gone a total of 3), it's been one of the "shouldBeQuick" tests every time which has nothing to do with these changes |
retire - Add change note. - Update logging in scan rules. Signed-off-by: kingthorin <[email protected]> # Conflicts: # addOns/retire/CHANGELOG.md
kingthorin
force-pushed
the
pscan-dont-log-at-error
branch
from
e17fe64 to
67f62a8
Compare
2 participants
Overview