-
-
Notifications
You must be signed in to change notification settings - Fork 88
Client Spider Support #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Great job, no security vulnerabilities found in this Pull Request |
9e7970f
to
7db890a
Compare
@psiinon fixed commit signatures. no way for me to rerun job. |
You need to do all of them. |
Signed-off-by: Johnathan P. Irvin <[email protected]>
Signed-off-by: Johnathan P. Irvin <[email protected]>
Signed-off-by: Johnathan P. Irvin <[email protected]>
7db890a
to
7d9d49d
Compare
@kingthorin thank you for clarification. should be fixed now. any other changes required? |
@kingthorin or @psiinon -- Any update? Looking to move this forward. |
If you want to move this forward generate the implementation instead of hand write it. |
The changelog should be updated. |
Where is the documentation to generate it automatically? Where should I place example usage? |
What should it say? |
Unable to get the build system to build the plugin to generate the api. Spent less time writing this simple addition then it takes to get automation tools to run. Maybe.. Will come back later. |
Signed-off-by: Johnathan P. Irvin <[email protected]>
Added change log per request. |
Adds the client spider to the python api.