-
Notifications
You must be signed in to change notification settings - Fork 9
[GH-15] WidgetbookにMaterial Componentを追加 #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ready for review 🚀 |
Visit the preview URL for this PR (updated for commit 5b4b47e): https://flutter-mobile-project-template-catalog--pr373-feature-6x7fh3l6.web.app (expires Fri, 24 Jan 2025 08:12:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dialog と同じような問題な気がします。。ただ、Dialog のように useRootNavigation: false
などの指定方法がないため、対応難しいかもしれません。
widgetbook/widgetbook#217
いったんは、このままでいいかなと思います 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue 化だけご対応お願いします 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#375 に作成しました 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM です!
ご対応ありがとうございます!
概要
#15
*Golden Test追加を別途対応します
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
量が多いためWidgetBook側で確認してもらいたいです 🙇
確認したこと
動作確認手順
備考