Skip to content

[GH-15] WidgetbookにMaterial Componentを追加 #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jan 17, 2025

Conversation

karas1910
Copy link
Contributor

概要

#15

  • Widgetbook に以下を追加する
    • Material Component 一覧
    • テキストスタイルを適用したテキスト一覧( textTheme.titleMedium など )
    • カラースキーマを適用したカラー一覧( colorScheme.primary など )

*Golden Test追加を別途対応します

レビュー観点

  • 要件を満たしているか

レビューレベル

  • Lv1: ぱっとみて違和感がないかチェックして Approve する
  • Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
  • Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

  • すぐに見てもらいたい ( hotfix など ) 🚀
  • 今日中に見てもらいたい 🚗
  • 今日〜明日中で見てもらいたい 🚶
  • 数日以内で見てもらいたい 🐢

画像 / 動画

量が多いためWidgetBook側で確認してもらいたいです 🙇

確認したこと

動作確認手順

備考

@github-actions github-actions bot added the @apps/catalog Catalog development label Jan 15, 2025
@yumemi-team-review-requester yumemi-team-review-requester bot requested review from a team, tatsutakein and blendthink and removed request for a team January 15, 2025 22:01
Copy link

Ready for review 🚀

Copy link

github-actions bot commented Jan 15, 2025

Visit the preview URL for this PR (updated for commit 5b4b47e):

https://flutter-mobile-project-template-catalog--pr373-feature-6x7fh3l6.web.app

(expires Fri, 24 Jan 2025 08:12:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23

@karas1910 karas1910 changed the title Feature/gh 15/add material widget [GH-15] WidgetbookにMaterial Componentを追加 Jan 15, 2025
Copy link
Contributor Author

@karas1910 karas1910 Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ask]
なぜか領域外に表示されてしまう、、、

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialog と同じような問題な気がします。。ただ、Dialog のように useRootNavigation: false などの指定方法がないため、対応難しいかもしれません。
widgetbook/widgetbook#217

いったんは、このままでいいかなと思います 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 化だけご対応お願いします 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#375 に作成しました 🙇

Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です!
ご対応ありがとうございます!

@karas1910 karas1910 merged commit 975b1ff into main Jan 17, 2025
13 checks passed
@karas1910 karas1910 deleted the feature/GH-15/add_material_widget branch January 17, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@apps/catalog Catalog development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants