Skip to content

ci: デプロイのCIを作成 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025
Merged

ci: デプロイのCIを作成 #33

merged 4 commits into from
Apr 22, 2025

Conversation

ygkn
Copy link
Member

@ygkn ygkn commented Mar 31, 2025

チケットURL

close #3

ラベル

概要

とりあえずPRだけ

確認用URL

スクリーンショット

その他

チェックリスト

  • 機能実装向け:ビルド、テストは正常に動作しますか?
  • 機能実装向け:意図していないデバッグコードはありませんか?
  • 機能実装向け:PRにレビュー優先度のラベルをつけましたか?
  • PRにレビューレベルのラベルをつけましたか?
  • ガイドライン向け: 変更箇所の日本語は適切ですか?
  • ガイドライン向け: 変更箇所のフォーマットは統一されていますか?

Sorry, something went wrong.

@ygkn ygkn requested a review from a team as a code owner March 31, 2025 07:28
@ygkn ygkn requested a review from Copilot April 22, 2025 08:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR creates a continuous integration deploy workflow to automate deployment to GitHub Pages.

  • Adds a new GitHub Actions workflow file (.github/workflows/deploy.yml) for deployment.
  • Divides the workflow into a build job (checkout, build site with Astro, and lint) and a deploy job (deploy using GitHub Pages action).

permissions:
contents: read
pages: write
id-token: write
Copy link
Preview

Copilot AI Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review whether the 'id-token: write' permission is strictly necessary; granting extra permissions that are not in use may introduce a potential security risk.

Suggested change
id-token: write

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

ryokatsuse
ryokatsuse previously approved these changes Apr 22, 2025
@ygkn ygkn merged commit a1764a2 into main Apr 22, 2025
1 check passed
@ygkn ygkn deleted the ci/deploy branch April 22, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Pages にデプロイする
3 participants