-
Notifications
You must be signed in to change notification settings - Fork 32
Lists Attributes #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lists Attributes #1556
Conversation
… enhancing attribute options and value handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty awesome update!
- Inherit flag will never make sense for lists, hide checkbox for lists.

- Use correct attribute icons for the filtering. getAttributeIcon.ts useBuildFilterOptions I think you can probably reuse this function?

- Filtering by number or text should allow for custom values to added. I think this might be solved by useBuildFilterOptions maybe.

- Number fields should show the aggregate of the numbers set on the lists. If list 1 has 100 and list 2 has 200 then we should see 100 and 200 as options for the attribute.
…to support dynamic value generation and improved icon handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Boolean attributes should always have Yes/No options like in the overview page.

- Filters are still stored on the user object but need to be stored on the view. Look at overview logic for how this is done as it requires some converting from queryFilters to filters that work with the component. Try to use the same logic/component.
…tegrate boolean attribute filtering logic with dynamic value generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I was wrong about the saving of the filters. Could we please go back to saving them on the user like before.
…improve reactivity and support user-scoped filter persistence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks!
Description of changes
This PR adds support for list-scoped attributes throughout the application, enabling attributes to be specifically assigned to and displayed within entity lists. This brings
list entities to feature parity with other entity types (folders, tasks, versions) in terms of attribute handling.
Key changes:
Technical details
Additional context
The approach maintains consistency with how attributes are handled in folder/task detail panels (useEntityFields.ts, NewEntityContext.tsx), ensuring uniform
behavior across all entity types.