Skip to content

Conversation

filipvnencak
Copy link
Collaborator

@filipvnencak filipvnencak commented Oct 3, 2025

Description of changes

This PR adds support for list-scoped attributes throughout the application, enabling attributes to be specifically assigned to and displayed within entity lists. This brings
list entities to feature parity with other entity types (folders, tasks, versions) in terms of attribute handling.

Key changes:

  • Added 'list' as a new scope option in the Attribute Editor
  • List attribute forms now fetch and display list-scoped attributes from the global attribute definitions
  • List filter dialog now includes list-scoped attributes as filterable options
  • Attributes with enum values are properly supported in list filters

Technical details

  • Fetches all attributes via useGetAttributeListQuery()
  • Filters by scope?.includes('list') (matching the pattern in useEntityFields.ts:128 for folders/tasks)
  • Merges list-scoped attributes with passed attributes in form fields
  • Stores scoped attribute values in the attrib object

Additional context

The approach maintains consistency with how attributes are handled in folder/task detail panels (useEntityFields.ts, NewEntityContext.tsx), ensuring uniform
behavior across all entity types.

Screenshot 2025-10-03 at 10 32 47

… enhancing attribute options and value handling
@filipvnencak filipvnencak self-assigned this Oct 3, 2025
@filipvnencak filipvnencak added the type: enhancement Improvement of existing functionality or minor addition label Oct 3, 2025
@filipvnencak filipvnencak requested a review from Innders October 3, 2025 08:33
@filipvnencak filipvnencak linked an issue Oct 3, 2025 that may be closed by this pull request
@filipvnencak filipvnencak marked this pull request as ready for review October 3, 2025 10:09
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty awesome update!

  • Inherit flag will never make sense for lists, hide checkbox for lists.
Image Image
  • Filtering by number or text should allow for custom values to added. I think this might be solved by useBuildFilterOptions maybe.
Image
  • Number fields should show the aggregate of the numbers set on the lists. If list 1 has 100 and list 2 has 200 then we should see 100 and 200 as options for the attribute.

@Innders Innders self-requested a review October 6, 2025 08:41
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Boolean attributes should always have Yes/No options like in the overview page.
Image
  • Filters are still stored on the user object but need to be stored on the view. Look at overview logic for how this is done as it requires some converting from queryFilters to filters that work with the component. Try to use the same logic/component.

…tegrate boolean attribute filtering logic with dynamic value generation
@filipvnencak filipvnencak requested a review from Innders October 6, 2025 10:00
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was wrong about the saving of the filters. Could we please go back to saving them on the user like before.

…improve reactivity and support user-scoped filter persistence
@filipvnencak filipvnencak requested a review from Innders October 7, 2025 13:20
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

@Innders Innders merged commit d53519f into develop Oct 8, 2025
@Innders Innders deleted the 1544-Lists-Attributes branch October 8, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lists Attributes

2 participants