Skip to content

Conversation

martastain
Copy link
Member

@martastain martastain commented Oct 2, 2025

This pull request enhances the color handling for enum cell values in the EnumCellValue component. The main improvement is the introduction of a utility to ensure text color remains readable against various background colors by dynamically determining whether to use black or white text.

Before

image

After

image

@martastain martastain linked an issue Oct 2, 2025 that may be closed by this pull request
@martastain martastain self-assigned this Oct 2, 2025
@martastain martastain requested a review from Innders October 2, 2025 09:30
@martastain martastain changed the title Tags are now readable Increased tags readability Oct 2, 2025
@martastain martastain added the type: bug Something isn't working label Oct 2, 2025
@filipvnencak
Copy link
Collaborator

Works well!

Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing in details header

Image

@BigRoy
Copy link
Contributor

BigRoy commented Oct 2, 2025

Missing in details header

Image

For what it's worth - in this case I find the white on pink more readable than the black on pink.
I wonder if the threshold is too low - or that maybe this just an odd one out?

@Innders
Copy link
Member

Innders commented Oct 3, 2025

I find the white on pink more readable than the black on pink

I agree, I think the thresholds need to be way higher for turning to black. And maybe the black should be more of an off black so it's not as harsh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Readable tags

4 participants