Skip to content

Fixes frame string formatting for transcoding #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025

Conversation

jakubjezek001
Copy link
Member

Changelog Description

Ensures the frame string used for transcoding includes the correct padding,
based on the collection's padding attribute. This resolves issues where
the output file sequence name was not correctly formatted, leading to
transcoding failures.

Additional info

I had found out about the issue during batchdelivery tests

Testing notes:

  1. only able to test this on higher then 4padding image sequence

Ensures the frame string used for transcoding includes the correct padding,
based on the collection's padding attribute. This resolves issues where
the output file sequence name was not correctly formatted, leading to
transcoding failures.
@jakubjezek001 jakubjezek001 self-assigned this May 16, 2025
@jakubjezek001 jakubjezek001 added the type: bug Something isn't working label May 16, 2025
@ynbot ynbot added the size/XS label May 16, 2025
@BigRoy
Copy link
Collaborator

BigRoy commented May 16, 2025

Isn't this exactly what the --framepadding argument is for in oiiotool.

I understand it's optional, but since it's a simple override optional why not just use that?

See: https://openimageio.readthedocs.io/en/latest/oiiotool.html#frame-sequences

Pretty sure I also used that and tested that in: #1217

@iLLiCiTiT
Copy link
Member

If --framepadding works, then please use that instead.

Copy link
Contributor

@rdelillo rdelillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR as this code works and fixes the issue.
If that's a urgent/critical bugfix, I believe this patch is good enough.

Now as flagged, there is a specific --framepadding argument that could be used here.
Just wanted to add that from my tests, --framepadding needs to be there along --frames.

# Works
oiiotool.exe --info -v -i:infoformat=xml C:/Users/robin/output.948845-948869%07.exr

# Works
oiiotool.exe --info -v -i:infoformat=xml C:/Users/robin/output.#.exr --frames 948845-948869 --framepadding 7

# Does NOT work
oiiotool.exe --info -v -i:infoformat=xml C:/Users/robin/output.948845-948869.exr --framepadding 7

@jakubjezek001 jakubjezek001 merged commit c5bfbb0 into develop May 23, 2025
2 checks passed
@jakubjezek001 jakubjezek001 deleted the bugfix/oiio-trancode-padding-issue branch May 23, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants