Skip to content

ExtractOIIOTranscode: Allow to process sequence of files in one oiiotool call #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Apr 23, 2025

Changelog Description

Allow to process sequence of files again in one oiiotool call

This fixes a degradation of performance introduced with this commit: d473118

Additional info

Correctly check whether sequence has any frames in the returned holes collection.

As per clique.Collection.holes documentation:

Return Collection of missing indexes.

This is a quick fix - for a bigger improvement in performance check out: #1217

Testing notes:

  1. ExtractOIIOTranscode should process sequences in a single oiiotool call again.

@BigRoy BigRoy added community Issues and PRs coming from the community members type: bug Something isn't working labels Apr 23, 2025
@BigRoy BigRoy self-assigned this Apr 23, 2025
@ynbot ynbot added the size/XS label Apr 23, 2025
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experimentaly compared returns of collection.holes() and collection.holes().indexes, makes sense.

@BigRoy BigRoy merged commit 192f2ca into ynput:develop Apr 25, 2025
2 checks passed
@BigRoy BigRoy deleted the bugfix/extract_oiio_transcode_fix_holes_check branch April 25, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants