Skip to content

add optional aov key to render template profile name #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

add optional aov key to render template profile name #1246

wants to merge 2 commits into from
+1 −1

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

resolve #1245

Testing notes:

  1. keep default settings value
  2. setup scene with AOV
  3. render product names should be unique.

@MustafaJafar MustafaJafar added the type: bug Something isn't working label Apr 15, 2025
@MustafaJafar MustafaJafar self-assigned this Apr 15, 2025
@ynbot ynbot added the size/XS label Apr 15, 2025
@MustafaJafar
Copy link
Contributor Author

Note:

I don't know if AOV key is implement in different integration addons however, using using optional brackets should be safe <_{Aov}>

@iLLiCiTiT iLLiCiTiT requested review from antirotor and removed request for iLLiCiTiT April 16, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy Awaiting requested review from BigRoy

@antirotor antirotor Awaiting requested review from antirotor

At least 1 approving review is required to merge this pull request.

Assignees

@MustafaJafar MustafaJafar

Labels
size/XS type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default render product name profile is not unique for each AOV
2 participants
@MustafaJafar @ynbot