Skip to content

Burnin size can auto adjust by image height #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jrsndl
Copy link
Contributor

@jrsndl jrsndl commented Mar 23, 2025

Changelog Description

This PR adds setting for Extract Burnin that allows auto adjusting the burnin size relative to image size height.

When creating full res and scaled down reviewables, it is hard to pick good burnin size. For example, good burnin size for UHD is unpleasantly big for 1080p.

Testing notes:

  1. Configure two extract review outputs with different output heights
  2. Enable Size relative to height option in Extract Burnin settings
  3. Check if Extracted reviewables burnin size matches (resize reviewables to the same size: fit height)

@ynbot ynbot added size/XS type: enhancement Improvement of existing functionality or minor addition labels Mar 23, 2025
@jrsndl
Copy link
Contributor Author

jrsndl commented Mar 23, 2025

for issue #1209

@iLLiCiTiT
Copy link
Member

I don't understand what it means to do? The title says auto adjust, but settings has "unit height", what is that for?

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 25, 2025

I don't understand what it means to do? The title says auto adjust, but settings has "unit height", what is that for?

I suppose it's about resizing font sizes relatively?
And I'd say "unit size" is the size at which you entered the current font sizes?

So that if unit size is say 1000 pixels, and you're rendering now at 2000 pixels then the font size would be 2x what you've entered in settings.
Similarly if you're rendering 500 pixels, the font size would become 0.5x what you have in settings.

Like:

size_ratio = current_size / unit_size
font-size *= size_ratio

@jrsndl
Copy link
Contributor Author

jrsndl commented Mar 27, 2025

@iLLiCiTiT @BigRoy

I suppose it's about resizing font sizes relatively? And I'd say "unit size" is the size at which you entered the current font sizes?

Exactly, it makes the text size (and other pixel values) to be the same relative size regardless of the image size.

There is often a need to make preview file that is typically >UHD, and editorial reviewable, typically HD. With "one size for all" approach, text is often too big or too small. Some projects also require different resolutions for different shots, relative burnin size makes the burnin look more consistent.

Sorry for not being clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants