Support conversion of project-specific settings #592
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
1 task
martastain
added
the
type: enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the conversion of project-specific settings by dynamically checking if the target addon’s conversion method expects a "project_name" parameter and, if so, passing it accordingly.
- Added import for the inspect module.
- Dynamically inspects the signature of convert_settings_overrides to conditionally include the "project_name".
Comments suppressed due to low confidence (1)
ayon_server/addons/addon.py:386
- If get_project_overrides is called frequently, consider caching the result of inspect.getfullargspec(target_addon.convert_settings_overrides) to reduce the overhead of repeated introspection.
if "project_name" in additional_args:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the conversion of project-specific settings by dynamically checking if the target addon’s conversion method expects a "project_name" parameter and, if so, passing it accordingly.