Improve message from refute on failure
#69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation was to `assert(!value)` which led to confusing failure messages when using `refute` directly. For custom failure messages, `!value` is always `false` on failure, so `false` is passed to the custom message block where the caller might instead expect the value that caused the failure. Similarly, the default failure message is always "expected false to be truthy" when really the expectation is that something truthy is falsy.
z1lk
force-pushed
the
improve-refute-message
branch
from
c4e3952 to
9039716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was to
assert(!value)which led to confusing failure messages when usingrefutedirectly.For custom failure messages,
!valueis alwaysfalseon failure, sofalsewas passed to the custom message block where the caller might instead expect the value that caused the failure.Similarly, the default failure message was always "expected false to be truthy" when really the expectation is that something truthy is falsy.