Add an ability to use multiple badges in a left sidebar menu item wit… #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h sub items Adding an ability to use multiple badges in a left sidebar menu item with sub items. Usage: [ 'label' => 'Label to Display', 'url' => './#', 'icon' => 'icon-name', 'badges' => [ ['content' => $some-numbers1, 'badgeOptions' => ['class' => 'some css class']] ['content' => $some-numbers2, 'badgeOptions' => ['class' => 'some css class']] ], 'items' => [ [ 'label' => 'Subitem 1', 'url' => ['/subitemUrl1'], 'icon' => 'subitem1-icon' ], [ 'label' => 'Subitem 2', 'url' => ['/subitemUrl2'], 'icon' => 'subitem1-icon' ], ], ]
fps01
reviewed
Dec 25, 2016
| @@ -1,7 +1,7 @@ | |||
| <?php | |||
| /** | |||
| * @copyright Copyright (c) 2015 Yiister | |||
| * @license https://github.com/yiister/yii2-adminlte/blob/master/LICENSE | |||
| * @license https://github.com/yiister/adminlte/blob/master/LICENSE | |||
| @@ -21,7 +21,7 @@ class Menu extends \yii\widgets\Menu | |||
| /** | |||
| * @inheritdoc | |||
| */ | |||
| public $linkTemplate = '<a href="{url}">{icon}<span>{label}</span>{badge}</a>'; | |||
| public $linkTemplate = '<a href="{url}">{icon}<span>{label}</span><span class="pull-right-container">{dropDownIcon}{badges}</span></a>'; | |||
There was a problem hiding this comment.
Implement dropDownIcon feature at the another pull request please.
| $badgeOptions = ArrayHelper::getValue($badge, 'badgeOptions', []); | ||
| Html::addCssClass($badgeOptions, 'label pull-right'); | ||
| $badges .= Html::tag('small', $badgeContent, $badgeOptions); | ||
| } |
There was a problem hiding this comment.
What if we have no array? This feature breaks a backward compatibility.
There was a problem hiding this comment.
I think that using of badge placeholder is a better solution for it. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h sub items
Usage:
[ 'label' => 'Personnes ', 'url' => './#', 'icon' => 'users', 'badges' => [ ['content' => Personne::find()->count(), 'badgeOptions' => ['class' => 'bg-aqua']] ], 'items' => [ [ 'label' => 'Liste des personnes', 'url' => ['/personne'], 'icon' => 'list' ], [ 'label' => 'Ajouter une personne', 'url' => ['/personne/create'], 'icon' => 'plus' ], ], ]