fix: make internal options and opt.width optional and match implementation #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Likewise, shall we land this now that I'm marginally more active again? |
|
I'll resolve conflicts hopefully in next few days or so. |
…ch the publis interface
shadowspawn
force-pushed
the
feature/optional-width
branch
from
a60c448 to
c46699d
Compare
|
The types are no longer being (accidentally) exported with the CJS implementation gone, so this is now a purely internal change. After some consideration and investigation, I made it way simpler than original version of PR! Just update types to match that the calling code may be passing in |
shadowspawn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation says the client can optionally supply options, and can optionally supply opt.width. The implementation supports this, but the typings did not. This is a minor change to match the intended and implemented client interface.
Fixes: #132
Side note: the type definition files are not being fully published currently. This PR improves the types but does not change what is published. One thing at a time.